DATACMNS-1126 - Add Kotlin constructor support. #233
Conversation
We now discover Kotlin constructors and apply parameter defaulting to allow construction of immutable value objects. Constructor discovery uses primary constructors by default and considers PersistenceConstructor annotations.
ClassGeneratingEntityInstantiator can instantiate Kotlin classes with default parameters by resolving the synthetic constructor. Null values translate to parameter defaults.
class Person(val firstname: String = "Walter") {
}
class Address(val street: String, val city: String) {
@PersistenceConstructor
constructor(street: String = "Unknown", city: String = "Unknown", country: String) : this(street, city)
}
mp911de
force-pushed
the
issue/DATACMNS-1126
branch
from
cd2b309 to
700775f
Compare
There was a problem hiding this comment.
Does it make sense to hide the dedicated constructor discoverer in BasicPersistentEntity's constructor? That avoids the first one to run in the first place. Looks like the already existing PreferredConstructorDiscoverer got a Kotlin code path as well now.
Also, I wonder If we can't have a dedicated Kotlin-aware EntityInstantiator to more cleanly separate that from the standard one. We should be able to detect that it's a Kotlin class we have to deal with and the just select the right EntityInstantiator in the first place, right?
|
I'd turn An |
Split preferred constructor discovery in enum types. Refactor PreferredConstructorDiscoverer to interface with static methods for constructor discovery. Adapt tests.
Refactor ClassGeneratingEntityInstantiator to ClassGeneratingEntityInstantiator without Kotlin-specifics and ClassGeneratingKotlinEntityInstantiator extending ClassGeneratingEntityInstantiator. Apply intantiation argument caching to ClassGeneratingEntityInstantiator.
… Kotlin.
We now discover Kotlin constructors and apply parameter defaulting to allow construction of immutable value objects. Constructor discovery uses primary constructors by default and considers PersistenceConstructor annotations.
KotlinClassGeneratingEntityInstantiator can instantiate Kotlin classes with default parameters by resolving the synthetic constructor. Null values translate to parameter defaults.
class Person(val firstname: String = "Walter") {
}
class Address(val street: String, val city: String) {
@PersistenceConstructor
constructor(street: String = "Unknown", city: String = "Unknown", country: String) : this(street, city)
}
Original pull request: #233.
Trailing whitespace in ReflectionUtils. Original pull request: #233.
Moved PreferredConstructorDiscoverers into PreferredConstructorDiscoverer to hide more API. Renamed ClassGeneratingKotlinEntityInstantiator to KotlinClassGeneratingEntityInstantiator. Original pull request: #233.
Moved PreferredConstructorDiscoverers into PreferredConstructorDiscoverer to hide more API. Renamed ClassGeneratingKotlinEntityInstantiator to KotlinClassGeneratingEntityInstantiator. Use org.springframework.util.Assert instead of com.mysema.commons.lang.Assert. Original pull request: #233.
We now discover Kotlin constructors and apply parameter defaulting to allow construction of immutable value objects. Constructor discovery uses primary constructors by default and considers
@PersistenceConstructorannotations.ClassGeneratingEntityInstantiatorcan instantiate Kotlin classes with default parameters by resolving the synthetic constructor. Null values translate to parameter defaults.